Nested fields for all types in common.Schema #7583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
schema-nested-fields
branch
2 times, most recently
from
2619e42
to
436e6c2
Compare
jsoriano
force-pushed
the
schema-nested-fields
branch
from
436e6c2
to
b469b6c
Compare
ycombinator
approved these changes
Jul 12, 2018
jsoriano
changed the title
|
@ruflin wdyt? |
|
+1 on this change. Tried to think of some edge cases that it could break but couldn't come up with any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to get nested fields from other types in
mapstrifacein common.Schema. It was already allowed onstringandinterface{}, added a test also to check the behaviour.Not sure however if this is the intended behaviour.