[WIP] Migrate to the new registry #7803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a global registry and the feature bundle.
Since a go plugin only works with a specific of golang and beats we can change the return value without changing the signature.
The autodiscovery feature was defining 3 customs registry, this PR do the following: - Provider, Appender and Builder now users the feature registry. - It move the Factory type into their right package. - Config are now inside their own package. - Use the same naming for finding factories and building object. - type aliasing is in place to make the transition smoother for types. - A shim is in place that will proxy the registry of plugin to the global registry. - package.Plugin methods are now returning a feature instead of a hashmap.
houndci-bot
reviewed
Jul 31, 2018
| // feature are grouped by namespace, a namespace is a kind of plugin like outputs, inputs, or queue. | ||
| // The feature name must be unique. | ||
| type registry struct { | ||
| type FeatureRegistry struct { |
There was a problem hiding this comment.
type name will be used as feature.FeatureRegistry by other packages, and that stutters; consider calling this Registry
houndci-bot
reviewed
Jul 31, 2018
| // feature are grouped by namespace, a namespace is a kind of plugin like outputs, inputs, or queue. | ||
| // The feature name must be unique. | ||
| type registry struct { | ||
| type FeatureRegistry struct { |
There was a problem hiding this comment.
type name will be used as feature.FeatureRegistry by other packages, and that stutters; consider calling this Registry
I've made a shims over the old registry and trid to minimize the changes needed to make it work, the RegisterActive will use the new registration behind the scene.
houndci-bot
reviewed
Aug 1, 2018
|
|
||
| type Registrar struct { | ||
| modules map[string]entry | ||
| type TaskRunner interface { |
There was a problem hiding this comment.
exported type TaskRunner should have comment or be unexported
on error since the majority of error is handled at the registry level.
houndci-bot
reviewed
Aug 1, 2018
|
|
||
| var Registry = newRegistrar() | ||
| type JobRunner func() (beat.Event, []JobRunner, error) |
There was a problem hiding this comment.
exported type JobRunner should have comment or be unexported
|
I am closing this and will reopen a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR for the documentation: #7392
Migration:
Notes TBD in another PR.: