-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing config options to Logstash section of reference.yml #7883
Conversation
No. We should add the deprecation notice to the config file. Setting will be removed in 7.0
10200 is actually correct. It's the one used in code. But for some reason we started documenting 5044 about everywhere. We will change the default to 5044 in beats. See #7881 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark port
as deprecated.
Checking the code we did change the default to 5044 at some point. |
Actually, since
|
b74f7ee
to
062fe2f
Compare
@urso This should be ready for a final review. |
…7937 #7939 #7948 #7949 #7950) (#8188) * Reset modulename attribute at the end of a file (#7888) * Add safeguard related statements for max_backoff setting (#7889) * Add docs about append_fields (#7903) * Add docs about append_fields * Remove experimental tag from setup.template.json.enabled description * Metricbeat: Add compatibility notes where missing (#7939) * Metricbeat: Add compatibility notes where missing, based on integration tests * Added review suggestions * Add missing config options to Logstash section of reference.yml (#7883) Closes #3062 * Fix processor autodiscovery docs for Filebeat (#7937) { needs escaping as otherwise asciidoc will show an empty code block. * Add document for beat export dashboard (#7696) * Add document for beat export dashboard Follow up from #7239 * move to command reference * address review comments * review comments applied * apply review feedback * Replace golang with Go (#7948) I've been told that using "golang" instead of "Go" is considered a faux pas in some circles. :-) I've replaced instances in the external docs, but I did not update the changelog, readmes, or code files. * Minor fixes to attributes in module docs (#7949) * Add recommendation to avoid harvesting symlinks when dealing with file rotation (#7950)
…elastic#8013) * Add missing config options to Logstash section of reference.yml (elastic#7883) * Add safeguard related statements for max_backoff setting (elastic#7889) * Add recommendation to avoid harvesting symlinks when dealing with file rotation (elastic#7950)
Closes #3062
A couple of open issues:
port
in the reference docs? (NO)port
is 10200, but the code here says 5044. I'll change it in the reference docs (assuming I'm reading the code correctly...let me know). (Fixed docs.)