Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL parameters to ES output #879

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

urso
Copy link

@urso urso commented Jan 28, 2016

Add config file option to elasticsearch output to pass additional parameters
with index operations.

Closes #805

@monicasarbu
Copy link
Contributor

LGTM

@@ -151,6 +151,9 @@ filebeat:
# Event count spool threshold - forces network flush if exceeded
#spool_size: 2048

# Enable async publisher pipeline in filebeat (Experimental!)
#publish_async: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will disappear on purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By disappear I mean: not part of the diff as it is already in master :-)

@ruflin
Copy link
Member

ruflin commented Jan 29, 2016

LGTM. Needs rebase.

Add config file option to elasticsearch output to pass additional parameters
with index operations.
@urso urso force-pushed the feature/805-es-http-params branch from 7a0eaa3 to 0e1f535 Compare January 29, 2016 10:45
ruflin added a commit that referenced this pull request Jan 29, 2016
@ruflin ruflin merged commit 3dd0bb1 into elastic:master Jan 29, 2016
@Bargs
Copy link

Bargs commented Jan 29, 2016

Could we document this config option in the Filebeat docs as well? I'll need docs to point users to from the Add Data UI so they can set up filebeat to send data through their ingest pipeline. As far as I can tell, libbeat/docs/outputconfig.asciidoc doesn't show up in the docs on the Elastic website anywhere.

@dedemorton
Copy link
Contributor

@Bargs outputconfig.asciidoc is a shared file. We pull the content of that file into the the documentation for all of the Beats (see the topic called Configuration Options). For example, you'll see the content here for Filebeat: https://www.elastic.co/guide/en/beats/filebeat/1.1/filebeat-configuration-details.html#configuration-output.

Of course, the link points to version 1.1, so you won't see the the parameters option, but you get the point.

@urso urso deleted the feature/805-es-http-params branch March 4, 2016 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants