Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename field offset to log.offset #8923

Merged
merged 6 commits into from
Nov 6, 2018
Merged

Rename field offset to log.offset #8923

merged 6 commits into from
Nov 6, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Nov 5, 2018

  • Update tests accordingly
  • Remove checks from JSON tests as log prefix now used for log.offset
  • Update generated files

@ruflin
Rename field offset to log.offset
abecd6d 
* Update tests accordingly
* Remove checks from JSON tests as log prefix now used for log.offset
* Update generated files
@ruflin
update files from suricata
ca4d012
@ruflin
add new fields.go
125c796
kvch
kvch reviewed Nov 6, 2018
View reviewed changes
filebeat/tests/system/test_registrar.py Outdated
@@ -845,6 +845,7 @@ def test_clean_inactive(self):
if os.name == "nt":
assert data[0]["offset"] == 3
else:
print data[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover debug message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed.

kvch
kvch reviewed Nov 6, 2018
View reviewed changes
filebeat/tests/system/test_registrar_upgrade.py Outdated
@@ -78,6 +78,7 @@ def run_and_validate(self):

data = self.get_registry()
assert len(data) == 1
print data[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also leftover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed

kvch
kvch approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@ruflin ruflin added the ecs label Nov 6, 2018
@ruflin ruflin mentioned this pull request Nov 6, 2018
Closed
@ruflin ruflin merged commit dc9edfd into elastic:master Nov 6, 2018
@ruflin ruflin deleted the log.offset branch November 6, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
ecs Filebeat Filebeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @kvch