-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kibana 5 dashboards and index patterns #8927
Conversation
Probably worth a changelog entry for both dev and non dev changelog? |
You probably also have to adjust the index_pattern generator. |
versionPath = "5" | ||
} | ||
return versionPath | ||
return strconv.Itoa(version.Major) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruflin tests are failing because of this change, according to tests, path should be 6/index-pattern
for all versions major to 5, is this correct? should we continue using the generated index patterns for version 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Today I would say yes but as far as I heard the structure on the Kibana side might change, so not sure if we need to adapt it. @skh is currently looking into these structure changes from the dashboard perspective.
To move this forward I would say for now lets stick to just 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I revert the change here and remove generation for 7.0 by now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tsg @monicasarbu for awareness.
Remove kibana 5 dashboards and index patterns generation for 7.0.