Add x-pack/filebeat to Travis CI #9184
Conversation
andrewkroh
force-pushed
the
feature/xpack-filebeat-travis-ci
branch
from
c6c660d
to
a4fb84e
Compare
|
@sayden I updated my copy of your mssql pull request to include these changes. And now your mssql stuff should be tested on travis too. Branch: https://github.com/andrewkroh/beats/tree/sayden-mssql-update If you'd find it convenient I can clean up this branch and open a PR to add MSSQL to |
This adds testing of x-pack/filebeat to travis CI. And includes x-pack/filebeat in the top-level `make check` target. In x-pack/filebeat I changed the integTest target to pre-build the Docker images to avoid any timeouts in the EnsureUp() calls. Bump the version of docker-compose on Travis to 1.22.0 the same as what's being used within the Docker images that we build. Add fmt and check to Mage. This adds a means to format code and check for modifications. These targets behave as follows: - `mage fmt` - Adds license headers, run goimports, and autopep8. - `mage check` - Runs fmt and update. Then checks to see if there were any modifications using git. And checks if any nosetests files or YAML files are executable.
andrewkroh
force-pushed
the
feature/xpack-filebeat-travis-ci
branch
from
a4fb84e
to
1bfcf3c
Compare
| ES_BEATS?=../.. | ||
| XPACK_BEAT_PATH?=github.com/elastic/beats/x-pack/${BEAT_NAME} | ||
| GOPACKAGES?=$(shell go list ${BEAT_PATH}/... ${XPACK_BEAT_PATH}/... | grep -v /vendor/ | grep -v /scripts/cmd/ ) | ||
| LICENSE=Elastic |
There was a problem hiding this comment.
Is the LICENSE part not needed anymore?
There was a problem hiding this comment.
It's not needed here because all of the real build logic originates from Mage in this case so we only need to set mage.BeatLicense = "Elastic" in the magefile.go.
There was a problem hiding this comment.
LGTM
@andrewkroh Would be great if you could contribute / help on the other branch too.
This adds testing of x-pack/filebeat to travis CI. And includes x-pack/filebeat in the
top-level
make checktarget.In x-pack/filebeat I changed the integTest target to pre-build the Docker images to
avoid any timeouts in the EnsureUp() calls.
Bump the version of docker-compose on Travis to 1.22.0 the same as what's being used within
the Docker images that we build.
Add fmt and check to Mage. This adds a means to format code and check for modifications.
These targets behave as follows:
mage fmt- Adds license headers, run goimports, and run autopep8.mage check- Runs fmt and update. Then checks to see if there were any modificationsusing git. And checks if any nosetests files or YAML files are executable.