Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky tests seen in #9194 #9217

Merged
merged 2 commits into from
Nov 23, 2018
Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 23, 2018

Skip flaky tests seen in #9194 (#9213, #9214, #9215, #9216)

@jsoriano jsoriano added review Filebeat Filebeat libbeat flaky-test Unstable or unreliable test cases. labels Nov 23, 2018
@jsoriano
Copy link
Member Author

jsoriano commented Nov 23, 2018

Umm, same tests failed 🤦‍♂️ maybe they are not so flaky, and I should have used os.name == 'nt', I'll try again.

@ph
Copy link
Contributor

ph commented Nov 23, 2018

@jsoriano Not they that aren't flaky, I think it's from the go 1.11.2 upgrade.

@ph ph mentioned this pull request Nov 23, 2018
8 tasks
@ruflin
Copy link
Member

ruflin commented Nov 23, 2018

@ph I think some of them were flaky before, just not that constant.

@ph
Copy link
Contributor

ph commented Nov 23, 2018

I think some of them were flaky before, just not that constant.

Correct, but I would say its more a permanent state now.

@jsoriano jsoriano merged commit a07884e into elastic:master Nov 23, 2018
@jsoriano jsoriano deleted the flaky-tests-9194 branch November 23, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat flaky-test Unstable or unreliable test cases. libbeat review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants