Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packetbeat] Restructure client/server and process fields #9303

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Nov 30, 2018

NOTE: Review the second commit to because this is based on #9121 (change flow fields) which has not been merged yet.

This is part of #7968.

Sample HTTP Event with Process metadata

Changed

  • client_ip - client.ip (changed to ip type)
  • client_port - client.port
  • client_server - client.domain
  • client_proc - client.process.name
  • client_cmdline - client.process.args (changed to an array)
  • direction - network.direction
  • ip - server.ip (changed to ip type)
  • port - server.port
  • server - server.domain
  • proc - server.process.name
  • cmdline - server.process.args (change to an array)

Added

  • client.process.executable
  • client.process.working_directory
  • client.process.pid
  • client.process.ppid
  • client.process.start
  • server.process.executable
  • server.process.working_directory
  • server.process.pid
  • server.process.ppid
  • server.process.start

The top-level process field is populated with the server.process
or client.process (server takes priority). Likewise for flows process
is populated with the destination.process or the client.process
(destination takes priority).

@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

packetbeat/procs/procs.go Show resolved Hide resolved
packetbeat/procs/procs.go Outdated Show resolved Hide resolved
libbeat/common/tuples.go Show resolved Hide resolved
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Changed

- client_ip - client.ip (changed to ip type)
- client_port - client.port
- client_server - client.domain
- client_proc - client.process.name
- client_cmdline - client.process.args (changed to an array)
- direction - network.direction
- ip - server.ip (changed to ip type)
- port - server.port
- server - server.domain
- proc - server.process.name
- cmdline - server.process.args (change to an array)

Added

- client.process.executable
- client.process.working_directory
- client.process.pid
- client.process.ppid
- client.process.start
- server.process.executable
- server.process.working_directory
- server.process.pid
- server.process.ppid
- server.process.start

The top-level `process` field is populated with the `server.process`
or `client.process` (server takes priority). Likewise for flows `process`
is populated with the `destination.process` or the `client.process`
(destination takes priority).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants