Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Filebeat redis.log to ECS #9315

Merged
merged 6 commits into from
Dec 19, 2018
Merged

Convert Filebeat redis.log to ECS #9315

merged 6 commits into from
Dec 19, 2018

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 30, 2018 •
edited
Loading

Caveats

  • The Redis slowlog dataset has no tests and an empty pipeline. Nothing to do there...

Renames

  • redis.log.level => log.level
  • redis.log.message => message
  • redis.log.pid => process.pid

TODO

  • Coerce PID to int
  • Alias renamed fields to their ECS counterpart
  • Document field migrations in ecs-migration.yml
  • Changelog

@webmat webmat self-assigned this Nov 30, 2018
@webmat webmat added in progress Pull request is currently in progress. module Filebeat Filebeat ecs labels Nov 30, 2018
@ruflin ruflin mentioned this pull request Nov 30, 2018
Closed
@webmat webmat mentioned this pull request Dec 17, 2018
Closed
14 tasks
@webmat webmat requested a review from a team as a code owner December 19, 2018 18:41
@webmat webmat changed the title WIP Convert Filebeat redis.log to ECS Convert Filebeat redis.log to ECS Dec 19, 2018
@webmat webmat added review and removed in progress Pull request is currently in progress. labels Dec 19, 2018
@webmat webmat merged commit 2209c46 into elastic:master Dec 19, 2018
@webmat webmat deleted the ecs-redis-fb branch December 19, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@webmat webmat

Labels
ecs Filebeat Filebeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmat @ruflin