Add OS Name into add-host-metadata #9405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
changed the title
ruflin
reviewed
Dec 6, 2018
There was a problem hiding this comment.
Can you add a changelog and also update the docs: https://www.elastic.co/guide/en/beats/filebeat/master/add-host-metadata.html
ruflin
reviewed
Dec 7, 2018
|
@ruflin thanks for the review! Yeah I found os.name already exists in _meta/fields.ecs.yml. |
exekias
approved these changes
Dec 7, 2018
ruflin
reviewed
Dec 7, 2018
CHANGELOG.asciidoc
Outdated
| @@ -95,6 +95,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d | |||
| - The `elasticsearch/node` metricset now reports the Elasticsearch cluster UUID. {pull}8771[8771] | |||
| - Add service.type field to Metricbeat. {pull}8965[8965] | |||
| - Support GET requests in Jolokia module. {issue}8566[8566] {pull}9226[9226] | |||
| - Add `os.name` field into libbeat add_host_metadat processor. {issue}8948[8948] {pull}9405[9405] | |||
There was a problem hiding this comment.
@kaiyan-sheng The PR still seems to contain the old changelog?
There was a problem hiding this comment.
oh man... sorry!! I somehow reversed it...
ruflin
approved these changes
Dec 7, 2018
|
closes #8948 |
kaiyan-sheng
added
needs_backport
kaiyan-sheng
added a commit
that referenced
this pull request
Dec 11, 2018
kaiyan-sheng
removed
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #8948
closes #8948