Introduce log.source.address and log.file.path for 7.x compatiblity #9435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
ruflin
added
review
and removed
in progress
ruflin
changed the title
ruflin
force-pushed
the
introduce-new-source-fields
branch
from
2cb7600
to
a31733e
Compare
|
Pinging @elastic/infrastructure |
|
This should not be merged before discussion in #9460 is resolved. |
ruflin
changed the title
ruflin
changed the title
ruflin
force-pushed
the
introduce-new-source-fields
branch
from
83a9f46
to
edfd916
Compare
|
PR was changed to use |
webmat
suggested changes
Dec 11, 2018
Related to elastic#8902 but adding the fields instead of replacing
ruflin
force-pushed
the
introduce-new-source-fields
branch
from
9b39084
to
8750ba1
Compare
webmat
reviewed
Dec 12, 2018
| @@ -17,6 +17,7 @@ | |||
| "http.request.method": "GET", | |||
| "http.response.status_code": "200", | |||
| "input.type": "log", | |||
| "log.file.path": "/Users/ruflin/Dev/gopath/src/github.com/elastic/beats/x-pack/filebeat/module/suricata/eve/test/eve-alerts.log", | |||
There was a problem hiding this comment.
These paths are still present in x-pack
There was a problem hiding this comment.
will update these files too and push again.
webmat
suggested changes
Dec 12, 2018
webmat
approved these changes
Dec 12, 2018
| @@ -1,6 +1,6 @@ | |||
| [ | |||
| { | |||
| "@timestamp": "2018-12-11T08:08:07.894Z", | |||
| "@timestamp": "2018-12-12T11:22:05.182Z", | |||
There was a problem hiding this comment.
Don't think it's a problem, but why are these timestamps still changing?
There was a problem hiding this comment.
I fixed that with #9506. It's not an issue for CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8902 but adding the fields instead of replacing