Add event.dataset to filebeat #9457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows 6.6 / 6.7 data to be compatible with 7.x.
ruflin
added
in progress
|
Pinging @elastic/infrastructure |
graphaelli
reviewed
Dec 11, 2018
| @@ -54,7 +55,7 @@ | |||
| "tags": [ | |||
| "suricata" | |||
| ], | |||
| "url.hostname": "example.net", | |||
| "url.hostname": "example.net", | |||
There was a problem hiding this comment.
bunch of these extra spaces, not sure if you care
There was a problem hiding this comment.
the files are auto generated so more wonder why there were missing before :-)
There was a problem hiding this comment.
Ah I may have saved it in a commit, before I was familiar with the Beats integration tests :-)
webmat
reviewed
Dec 11, 2018
| - name: event.dataset | ||
| description: > | ||
| The Filebeat dataset that generated this event. | ||
|
|
There was a problem hiding this comment.
Nice, so we have per-Beat override 👍
|
@graphaelli Good question about the test. I don't think we should enforce it (event though at the moment it is because it's in the code). More important for me is that it's correct in the generate files. Ok if for now we skip a test? |
graphaelli
approved these changes
Dec 11, 2018
|
sounds reasonable to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows 6.6 / 6.7 data to be compatible with 7.x.