Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unix.Dup2 in RedirectStandardError #9493

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Conversation

urso
Copy link

@urso urso commented Dec 11, 2018

The function syscall.Dup2 does not exist for all architectures in the
stdlib, but the unix.Dup2 does. Replace it, so to fix compilation on
other os/arch combinations.

The function syscall.Dup2 does not exist for all architectures in the
stdlib, but the unix.Dup2 does. Replace it, so to fix compilation on
other os/arch combinations.
@urso urso requested a review from ph December 11, 2018 16:53
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso
Copy link
Author

urso commented Dec 12, 2018

Jenkins, test this.

@urso urso merged commit 5d79657 into elastic:master Dec 13, 2018
@urso urso deleted the dup2_stderr_other branch February 19, 2019 18:44
lichuan0620 pushed a commit to caicloud/beats that referenced this pull request Mar 6, 2020
The function syscall.Dup2 does not exist for all architectures in the
stdlib, but the unix.Dup2 does. Replace it, so to fix compilation on
other os/arch combinations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants