Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky ml test by increasing timeout #9523

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Dec 13, 2018

The ml tests sometimes fail on Travis or Jenkins but it seems when looking at the output of the files normally all entries are there. As they pass most of the time I assume it is an issue related to the timeout. Increasing the timeout to 60s.

The ml tests sometimes fail on Travis or Jenkins but it seems when looking at the output of the files normally all entries are there. As they pass most of the time I assume it is an issue related to the timeout. Increasing the timeout to 60s.
@ruflin ruflin added review libbeat :Testing flaky-test Unstable or unreliable test cases. labels Dec 13, 2018
@ruflin
Copy link
Member Author

ruflin commented Dec 13, 2018

jenkins, test this

@ruflin
Copy link
Member Author

ruflin commented Dec 13, 2018

This should fix #8359

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know why this takes so long, but I guess this is fine by now to reduce flakyness.

@ruflin ruflin merged commit 220cdee into elastic:master Dec 13, 2018
@ruflin ruflin deleted the flaky-ml-test branch December 13, 2018 13:38
@ruflin
Copy link
Member Author

ruflin commented Dec 13, 2018

@jsoriano me too. My assumption is that Travis just does not have enough memory available for ML so everything is really slow. I'll keep the related issue for now so we can keep tracking it.

ruflin added a commit to ruflin/beats that referenced this pull request Dec 13, 2018
The ml tests sometimes fail on Travis or Jenkins but it seems when looking at the output of the files normally all entries are there. As they pass most of the time I assume it is an issue related to the timeout. Increasing the timeout to 60s.

(cherry picked from commit 220cdee)
@ruflin ruflin added the v6.6.0 label Dec 13, 2018
ruflin added a commit that referenced this pull request Dec 14, 2018
The ml tests sometimes fail on Travis or Jenkins but it seems when looking at the output of the files normally all entries are there. As they pass most of the time I assume it is an issue related to the timeout. Increasing the timeout to 60s.

(cherry picked from commit 220cdee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants