-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix base fields in ECS file #9619
Conversation
fd5bd64
to
c3a360b
Compare
@@ -3,7 +3,50 @@ | |||
description: > | |||
ECS fields. | |||
fields: | |||
|
|||
|
|||
- name: "@timestamp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should/could we change how the fields.yml file in elastic/ecs is generated to make it match this format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current fields.yml
file is a simple concatenation of all of the different field definition files. ECS has more keys in there, which are ECS specific.
So we'll likely need to put together a script that strips out these keys and produces what Beats expects...
Would it make sense to have this script live in Beats, since it's an adaptation of the schema to Beats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like the Jenkins failure is due to capacity issues over there.
@@ -3,7 +3,50 @@ | |||
description: > | |||
ECS fields. | |||
fields: | |||
|
|||
|
|||
- name: "@timestamp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current fields.yml
file is a simple concatenation of all of the different field definition files. ECS has more keys in there, which are ECS specific.
So we'll likely need to put together a script that strips out these keys and produces what Beats expects...
Would it make sense to have this script live in Beats, since it's an adaptation of the schema to Beats?
I'm actually thinking to adjust the ECS fields.yml but need to figure out why. I think the two should be in sync. |
c3a360b
to
26eb2e6
Compare
So far the base fields of ECS were not read as they were nested under base. This brings them to the top level and resolves all the conflicts with field definitions in libbeat and other Beats.
26eb2e6
to
d9f1852
Compare
I created a follow up issue for the discussion around the structure unification. elastic/ecs#292 |
So far the base fields of ECS were not read as they were nested under base. This brings them to the top level and resolves all the conflicts with field definitions in libbeat and other Beats.
So far the base fields of ECS were not read as they were nested under base. This brings them to the top level and resolves all the conflicts with field definitions in libbeat and other Beats.
Moving forward we must find a better way for writing the ECS file to Beats as this step has to be done manually each time.