Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all alias with migration:true #9623

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Dec 18, 2018

To enable the migration layer with aliases in 7.x we need to know which aliases come from the migration and which ones were introduced for example by a user to not turn these off too. For this all alias have become migration: true entry and these aliases will be turned off by default. The current assumption is all alias that exist are for migration so it was added to all aliases.

This PR does not contain any code to support the migration: true in the template generation.

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the files so far look good. But you need to get rid of that doc entry for .DS_Store.asciidoc 😂

@ruflin ruflin force-pushed the migrate-alias branch 2 times, most recently from a39a239 to 8b9566e Compare December 21, 2018 13:35
@webmat
Copy link
Contributor

webmat commented Dec 21, 2018

@ruflin I just figured out this problem on one of my PRs.

Recently merged #9724 should have deleted x-pack/auditbeat/fields.go. So now rebases conflict on it, but make update no longer generates the file, so the merge conflict doesn't get overwritten.

So just delete it and I think you'll be fine.

@ruflin ruflin force-pushed the migrate-alias branch 2 times, most recently from 48e57ba to df9f28b Compare December 27, 2018 08:44
To enable the migration layer with aliases in 7.x we need to know which aliases come from the migration and which ones were introduced for example by a user to not turn these off too. For this all alias have become `migration: true` entry and these aliases will be turned off by default. The current assumption is all alias that exist are for migration so it was added to all aliases.
@ruflin ruflin added the Team:Integrations Label for the Integrations team label Dec 27, 2018
@ruflin ruflin merged commit 494d5ac into elastic:master Dec 27, 2018
@ruflin ruflin deleted the migrate-alias branch December 27, 2018 11:58
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
To enable the migration layer with aliases in 7.x we need to know which aliases come from the migration and which ones were introduced for example by a user to not turn these off too. For this all alias have become `migration: true` entry and these aliases will be turned off by default. The current assumption is all alias that exist are for migration so it was added to all aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecs review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants