Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing changes to os file set from ECS Beta 2 #9763

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Dec 21, 2018

Most of the Beta 2 update was done via #9645 and #9738. Only thing left is the last changes to the os field set.

Since this is a reusable field set, the same modifications occur in multiple places. This is not Groundhog day, don't worry.

Changes:

  • Tweak to os.name definition
  • Add os.full field
  • Change os.version example

@webmat webmat requested a review from a team as a code owner December 21, 2018 19:55
@ruflin ruflin mentioned this pull request Dec 21, 2018
@webmat webmat self-assigned this Dec 21, 2018
@webmat webmat changed the title WIP Importing changes to os file set from ECS Beta 2 Importing changes to os file set from ECS Beta 2 Dec 21, 2018
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The part I still worry is that this bloats the template unnecessary as these fields are not used yet by any Beat.

Mathieu Martin added 2 commits January 3, 2019 13:33
- Add `os.full`
- Change `os.name` description
- Change `os.version` example
@webmat
Copy link
Contributor Author

webmat commented Jan 3, 2019

@ruflin This is adding one field per index. Shouldn't be too bad :-)

@webmat webmat merged commit 5b3066f into elastic:master Jan 3, 2019
@webmat webmat deleted the ecs-os-beta2-update branch January 3, 2019 20:15
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
- Add field `os.full`
- Tweak `os.name` description
- Tweak `os.version` example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants