Allow multiple object types per field. #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 22, 2018
ruflin
reviewed
Dec 24, 2018
houndci-bot
reviewed
Jan 2, 2019
…amic-templates-per-field
jsoriano
reviewed
Jan 2, 2019
jsoriano
approved these changes
Jan 3, 2019
|
@ruflin PR is ready for another review, failing tests are unrelated from what I see. |
…amic-templates-per-field
ruflin
approved these changes
Jan 7, 2019
| @@ -119,20 +121,28 @@ func (p *Processor) integer(f *common.Field) common.MapStr { | |||
| return property | |||
| } | |||
|
|
|||
| func (p *Processor) scaledFloat(f *common.Field) common.MapStr { | |||
| func (p *Processor) scaledFloat(f *common.Field, params ...common.MapStr) common.MapStr { | |||
| property := getDefaultProperties(f) | |||
| property["type"] = "scaled_float" | |||
|
|
|||
| if p.EsVersion.IsMajor(2) { | |||
There was a problem hiding this comment.
@urso Not related to this PR but stumbled over it here. Should we remove these checks in master to clean up the code? 7.0 with 2 is not really supported.
simitt
added a commit
to simitt/beats
that referenced
this pull request
Jan 11, 2019
simitt
added a commit
that referenced
this pull request
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring multiple object types for the same field, to allow creating multiple dynamic templates on dynamic attributes, where keys are unknown.
Usage:
precondition for elastic/apm-server#1712