Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to controller-runtime v0.2 logging package #1708

Closed
charith-elastic opened this issue Sep 11, 2019 · 6 comments
Closed

Switch to controller-runtime v0.2 logging package #1708

charith-elastic opened this issue Sep 11, 2019 · 6 comments
Labels
good first issue Good for newcomers justdoit Continuous improvement not related to a specific feature

Comments

@charith-elastic
Copy link
Contributor

charith-elastic commented Sep 11, 2019 •
edited
Loading

Depends on #1188 and relates to #1699

  • pkg/runtime/log package is now deprecated and we should switch to pkg/log instead.
  • pkg/log/zap provides configuration functions that can be used to simplify our logging configuration at pkg/utils/log
@charith-elastic charith-elastic added good first issue Good for newcomers justdoit Continuous improvement not related to a specific feature labels Sep 11, 2019
@racevedoo
Copy link
Contributor

@charith-elastic Can I take a look at this? I'd like to start contributing

@charith-elastic
Copy link
Contributor Author

Sure; I don't think anyone else has started working on it.

@racevedoo
Copy link
Contributor

great! I'll ping when I have a PR ready

racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Sep 26, 2019
@racevedoo
change controller-runtime pkg/runtime/log to pkg/log (elastic#1708)
a47e108
@racevedoo racevedoo mentioned this issue Sep 26, 2019
Merged
@racevedoo
Copy link
Contributor

@charith-elastic just opened a PR (#1808) for the pkg/runtime/log part. Another will follow for the zap refactor you mentioned.

charith-elastic pushed a commit that referenced this issue Sep 27, 2019
@racevedoo @charith-elastic
Change controller-runtime pkg/runtime/log to pkg/log (#1808)
e888a37 
* change controller-runtime pkg/runtime/log to pkg/log (#1708)

* remove unnecessary log config from tests
racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
use controller-runtime zap package for logging config (elastic#1708)
d91401f
@racevedoo
Copy link
Contributor

@charith-elastic Remaining PR opened! #1828

racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
use controller-runtime zap package for logging config (elastic#1708)
6ef1aac
charith-elastic pushed a commit that referenced this issue Oct 1, 2019
@racevedoo @charith-elastic
use controller-runtime zap package for logging config (#1708) (#1828)
e77f218
@charith-elastic
Copy link
Contributor Author

Fixed by #1808 and #1828
Thanks @racevedoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers justdoit Continuous improvement not related to a specific feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@racevedoo @charith-elastic