Disable serving prometheus metrics by default #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently fixed how a port passed as "0" disables prometheus metrics. But kept the default value of 8080, which means metrics are enabled by default. I think this should be opt-in. The port is not set in the operator pod resource anyway.
|
LGTM. docs/operator-config.asciidoc will need to be updated as well but that is true of a bunch of things in this release I think |
anyasabo
approved these changes
Oct 8, 2019
thbkrkr
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently fixed how the metrics flag passed with "0" disables prometheus metrics.
But kept the default value of 8080, which means metrics are enabled by
default.
I think this should be opt-in. The port is not set in the operator pod
resource anyway.