Add CI job to run e2e tests in vanilla K8s with Kind #2056
Conversation
artemnikitin
added
:ci
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
| @@ -36,6 +36,7 @@ ci-internal: ci-build-image | |||
| -v /var/run/docker.sock:/var/run/docker.sock \ | |||
| -v $(ROOT_DIR):$(GO_MOUNT_PATH) \ | |||
| -w $(GO_MOUNT_PATH) \ | |||
| --network="host" \ | |||
There was a problem hiding this comment.
Otherwise we can't access kind cluster within container
| @@ -33,7 +33,7 @@ spec: | |||
| containers: | |||
| - name: e2e | |||
| image: {{ .E2EImage }} | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
I remember this conversation: #1995 (comment).
Is it important to cache the image?
There was a problem hiding this comment.
Without this change tests will not work in Kind. For unknown reasons for me, it can't pull image. We even have a special script to load images into kind https://github.com/elastic/cloud-on-k8s/blob/master/hack/kind/kind.sh#L137
Probably @barkbay can explain better why do we need to load images in kind when he will be back...
There was a problem hiding this comment.
IIRC, the docker images need to be pre-loaded into Kind nodes because there's no registry to pull the images from. When I changed the image pull policy, we didn't have Kind tests yet and it was just convenient to have that setting committed to Git to help test uncommited changes in a GKE cluster.
I think reverting to IfNotPresent makes sense now.
| @@ -33,7 +33,7 @@ spec: | |||
| containers: | |||
| - name: e2e | |||
| image: {{ .E2EImage }} | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
IIRC, the docker images need to be pre-loaded into Kind nodes because there's no registry to pull the images from. When I changed the image pull policy, we didn't have Kind tests yet and it was just convenient to have that setting committed to Git to help test uncommited changes in a GKE cluster.
I think reverting to IfNotPresent makes sense now.
This PR introduces new CI job which will run e2e tests on different versions of vanilla K8s using Kind.
Job will run tests on 1.11, 1.15 and 1.16. Why these versions?
We don't test on 1.11 in GKE anymore but still support it. 1.15 and 1.16 are not available in cloud services. Probably it doesn't make sense to test on 1.12, 1.13 or 1.14 because we are already testing on them in GKE.