Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module prometheus/common to v0.14.0 #3780

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 24, 2020

This PR contains the following updates:

Package Type Update Change
github.com/prometheus/common require minor v0.10.0 -> v0.14.0

Release Notes

prometheus/common

v0.14.0

Compare Source

v0.14.0

v0.13.0

Compare Source

v0.13.0

v0.12.0

Compare Source

v0.11.1

Compare Source

v0.11.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Sep 24, 2020
@barkbay barkbay assigned barkbay and unassigned barkbay Sep 28, 2020
@barkbay
Copy link
Contributor

barkbay commented Oct 1, 2020

2020/10/01 07:42:15 Failed to detect licences: no licence file found for github.com/lightstep/lightstep-tracer-common/golang/gogo. Add an override entry with licence type to continue.

I tried to override it:

{"name": "github.com/lightstep/lightstep-tracer-common/golang/gogo", "url": "https://github.com/lightstep/lightstep-tracer-common"}

But it does not seem to work, @charith-elastic could you help me to understand how to fix it please ?

@barkbay
Copy link
Contributor

barkbay commented Oct 15, 2020

I was wondering if I was the only one to think that the amount of dependencies added by this PR is a bit "excessive" and stumbled upon this: prometheus/common#255

It is a bit sad to have that huge dep tree just to parse the Prometheus output.

I'm wondering if I'll not write a small internal parser to avoid that ?

Note that the size of the operator is not impacted.

@pebrc
Copy link
Collaborator

pebrc commented Oct 15, 2020

I'm wondering if I'll not write a small internal parser to avoid that ?

I think that is a good idea, especially given that we want to parse only one very well understood metric for this e2e test.

@barkbay
Copy link
Contributor

barkbay commented Oct 16, 2020

Looks like all those dependencies have finally also landed in the Prometheus client: https://github.com/elastic/cloud-on-k8s/pull/3847/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 😕

@barkbay
Copy link
Contributor

barkbay commented Oct 23, 2020

Superseded by #3875

@barkbay barkbay closed this Oct 23, 2020
@renovate
Copy link
Contributor Author

renovate bot commented Oct 23, 2020

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (v0.14.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/git.luolix.top-prometheus-common-0.x branch October 23, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants