Allow watching cluster-scoped resources when using the multi-namespace cache #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cache
When managing resources in a single namespace, we rely on the controller-runtime
opts.Namespace feature, which implicitly allows watching cluster-scoped resources.
When managing resources in more than one namespace, we rely on opts.NewCache,
which takes a function to setup a multi-namespace cache. This cache does not
allows watching cluster-scoped resources by default. Which leads to error
when it tries to get storage classes:
```
cannot retrieve storage class: unable to get: /standard because of unknown namespace for the cache
```
This commit fixes it by ensuring we always append the empty namespace ("") to the
multi-namespace cache, so we can retrieve cluster-scoped storage classes if allowed
by the --validate-storage-class flag.
david-kow
reviewed
Oct 7, 2020
david-kow
approved these changes
Oct 7, 2020
david-kow
changed the title
david-kow
added
the
exclude-from-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When managing resources in a single namespace, we rely on the controller-runtime
opts.Namespace feature, which implicitly allows watching cluster-scoped resources.
When managing resources in more than one namespace, we rely on opts.NewCache,
which takes a function to setup a multi-namespace cache. This cache does not
allows watching cluster-scoped resources by default. Which leads to error
when it tries to get storage classes:
This commit fixes it by ensuring we always append the empty namespace ("") to the
multi-namespace cache, so we can retrieve cluster-scoped storage classes if allowed
by the --validate-storage-class flag.