Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module prometheus/client_golang to v1.8.0 #3847

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 15, 2020

This PR contains the following updates:

Package Type Update Change
github.com/prometheus/client_golang require minor v1.7.1 -> v1.8.0

Release Notes

prometheus/client_golang

v1.8.0

Compare Source

  • [CHANGE] API client: Use time.Time rather than string for timestamps in RuntimeinfoResult. #​777
  • [FEATURE] Export MetricVec to facilitate implementation of vectors of custom Metric types. #​803
  • [FEATURE API client: Support /status/tsdb endpoint. #​773
  • [ENHANCEMENT] API client: Enable GET fallback on status code 501. #​802
  • [ENHANCEMENT] Remove Metric references after reslicing to free up more memory. #​784

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Oct 15, 2020
@barkbay
Copy link
Contributor

barkbay commented Oct 16, 2020

I'm wondering if we should not exclude github.com/prometheus/client_golang and github.com/prometheus/common in the renovate config file.
We are using those libraries in a very limited way: only to build gauges and parse the Prometheus text format in one of our e2e test. It seems a bit odd to me track and document all those new dependencies.

I think it is acceptable to not upgrade them for now and maybe wait for prometheus/common#255 to be resolved.

@anyasabo
Copy link
Contributor

I'm good with that. It's not responsible for exposing a server so our risk is minimal I think. If we had a way to auto merge these PRs I would feel differently, but since it requires extra toil for not much benefit right now I'm good with it.

@barkbay
Copy link
Contributor

barkbay commented Oct 23, 2020

Superseded by #3875

@barkbay barkbay closed this Oct 23, 2020
@renovate
Copy link
Contributor Author

renovate bot commented Oct 23, 2020

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (v1.8.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/git.luolix.top-prometheus-client_golang-1.x branch October 23, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants