Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy v1beta1 CRDs #5029

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Nov 9, 2021

Remove legacy v1beta1 CRDs, which removes the support of OpenShift 3.11 (4ca3965) and Kubernetes <1.16 (e8d15f1, ceb9890).

Resolves #4885.

Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the manifest generator has test cases for k8s 1.13 that we could probably remove as well wdyt?

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Nov 15, 2021

the manifest generator has test cases for k8s 1.13 that we could probably remove as well wdyt?

Yes I missed this part and I would even go further and remove all conditional code in the templates 3e6c79b, or do you see a reason to keep it?

Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hack/manifest-gen/templatize/.gitignore Outdated Show resolved Hide resolved
@pebrc
Copy link
Collaborator

pebrc commented Nov 17, 2021

One more thing: we still have config/all-in-one.yaml file, I think this is a left-over from when I split up the manifests and I believe it should be safe to remove as well.

@thbkrkr thbkrkr merged commit 97676fd into elastic:master Nov 17, 2021
@thbkrkr thbkrkr deleted the remove-legacy-crds branch December 10, 2021 09:32
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
which removes support of OpenShift 3.11 and Kubernetes <1.16.

- Remove legacy CRDs references in the docs
- Remove OpenShift 3.11 from the supported versions
- Update OperatorHub CSV minKubeVersion to 1.16
- Remove legacy CRDs generation from Makefile and manifest-gen
- rm -rf config/crds/v1beta1
- rm -rf hack/manifest-gen/templatize
- rm -f config/all-in-one.yaml
- Remove manifest-gen test case for k8s 1.13
- Drop k8s <1.16 CRDs legacy support from manifest-gen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for legacy CRDs (k8s < 1.16)
2 participants