-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy v1beta1 CRDs #5029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the manifest generator has test cases for k8s 1.13 that we could probably remove as well wdyt?
Yes I missed this part and I would even go further and remove all conditional code in the templates 3e6c79b, or do you see a reason to keep it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One more thing: we still have |
which removes support of OpenShift 3.11 and Kubernetes <1.16. - Remove legacy CRDs references in the docs - Remove OpenShift 3.11 from the supported versions - Update OperatorHub CSV minKubeVersion to 1.16 - Remove legacy CRDs generation from Makefile and manifest-gen - rm -rf config/crds/v1beta1 - rm -rf hack/manifest-gen/templatize - rm -f config/all-in-one.yaml - Remove manifest-gen test case for k8s 1.13 - Drop k8s <1.16 CRDs legacy support from manifest-gen
Remove legacy
v1beta1
CRDs, which removes the support of OpenShift 3.11 (4ca3965) and Kubernetes <1.16 (e8d15f1, ceb9890).Resolves #4885.