Implement organizations API. #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the APIs for managing the organization: - Get/List/Update organizations - List/Create/Delete organization invitations - List/Delete organization members - Add/Remove organization member role assignments (API docs: https://www.elastic.co/guide/en/cloud/current/Organizations.html)
gigerdo
force-pushed
the
add-organization-api
branch
from
0f3d6bd
to
5f5f60d
Compare
10 tasks
nick-benoit
reviewed
Sep 9, 2024
| if got != nil && !assert.Equal(t, test.want, *got) { | ||
| t.Error(err) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Maybe a nit, but it seems like we wouldn't verify want == got if got is nil. It seems like we would maybe want to fail the test in that case?
There was a problem hiding this comment.
Yeah, true. It is done this way to ensure the 'want' is not checked when an error is expected. But I think I can write this in a clearer way:
if test.err != "" {
assert.EqualError(t, err, test.err)
assert.Nil(t, got)
} else {
assert.NoError(t, err)
assert.Equal(t, test.want, *got)
}
There was a problem hiding this comment.
I updated all tests to use this format.
nick-benoit
reviewed
Sep 9, 2024
| if err != nil && !assert.EqualError(t, err, test.err) { | ||
| t.Error(err) | ||
| } | ||
| if got != nil && !assert.Equal(t, test.want, *got) { |
There was a problem hiding this comment.
Just commenting here so that if a change is made for the prior comment RE: failing the test if got == nil it also gets made here.
nick-benoit
approved these changes
Sep 9, 2024
Clearly check either the error case or the successful result case.
gigerdo
force-pushed
the
add-organization-api
branch
from
59be954
to
4ceec3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the APIs for managing an Elastic cloud organization and its members.
(https://www.elastic.co/guide/en/cloud/current/Organizations.html)
This change is needed to implement RBAC support in terraform-provider-ec
Description
Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist