Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set saas endpoint as global to skip region checks #483

Merged

Conversation

claudia-correia
Copy link
Contributor

Description

Updates the list of global APIs to include the /saas endpoint.

Related Issues

https://elasticco.atlassian.net/browse/CP-7863

Motivation and Context

The /saas/billing/prices endpoint is a global endpoint that doesn't require the /regions/$region prefix. However, if this endpoint isn't added to the global list, trying to use it in the cloud-cli code without specifying a region in the context will result in this error the requested operation requires a region but none has been set.

How Has This Been Tested?

Tested using the new cloud-cli changes from https://github.com/elastic/cloud-cli/pull/1525, which perform a GET /saas/billing/prices request.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@claudia-correia claudia-correia added the bug Something isn't working label Sep 10, 2024
@claudia-correia claudia-correia requested a review from a team as a code owner September 10, 2024 10:48
@claudia-correia claudia-correia merged commit 0925099 into elastic:master Sep 11, 2024
2 checks passed
@claudia-correia claudia-correia deleted the set-saas-api-as-global branch September 11, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants