-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Asset Inventory][Azure] Add test cases and installation script #2498
Conversation
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
3e8dc33
to
803411a
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
78987f8
to
fa049b4
Compare
…at into azure-asset-inventory-it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Just some small comments. Maybe it's good that @gurevichdmitry have a look even if you merge today
run: poetry run pytest -k "asset_inventory_azure" --alluredir=./allure/results/ --clean-alluredir | ||
|
||
- name: Upload test results | ||
if: ${{ always() }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have an if always?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that it uploads results even if the previous step fails. Otherwise it skips all following steps, including this one.
It's a copy of regular Azure action.
@@ -67,6 +67,11 @@ jobs: | |||
shell: bash | |||
run: terraform fmt -check -recursive | |||
|
|||
- name: Show git diff on failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was missing this - now it shows you what the diff is if pre-commit
results in changes. I was having trouble replicating linter output on my machine.
current_version=package_version, | ||
required_version=PKG_DEFAULT_VERSION, | ||
): | ||
logger.warning(f"{INTEGRATION_NAME} is not supported in version {package_version}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are sys.exiting it, feels like a error deserving log 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a copy of what other scripts are doing, but sure, I can bump log level.
Ok. Merging. I can change log levels in a separate PR if important. |
Summary of your changes
Add integration test suite and installation scripts for Azure Asset Inventory.
Screenshot/Data
Related Issues
Closes https://github.com/elastic/security-team/issues/10320
Requires elastic/integrations#11125 & elastic/integrations#11167 to be merged first
Checklist