[DO NOT MERGE] Add Concurrency in GCS #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekziade
reviewed
Jan 3, 2023
tarekziade
reviewed
Jan 3, 2023
tarekziade
reviewed
Jan 3, 2023
|
see #256 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses changes suggested for concurrency in GCS as we discussed in #256.
While unit testing, a
server disconnectederror was encountered, which is an open issue in the aiohttp.We assume this is because multiple open connections are being used at the time, as before the concurrency change we were not facing this issue.
Please let us know your thoughts on this approach.
Also please don't merge this PR directly as we have to go through one round of testing once the approach is finalized.
Pre-Review Checklist