Support custom markers #76
Conversation
|
@thbkrkr PTAL |
|
Hi @zirain, I saw your PR but it's been a super busy week. It looks good in principle. We haven't been very good at updating the doc recently with all possible features. What do you think about adding a features section at the bottom of the readme and briefly detailing this new one? |
sure, will do it later. |
| continue | ||
| } | ||
|
|
||
| if err := registry.Define(marker.Name, t, struct{}{}); err != nil { |
There was a problem hiding this comment.
Should we support custom markers with value?
I think that by defining the custom marker with the output type struct{}{}, it is not possible to have a custom marker with a value. It is kind of a shame.
There was a problem hiding this comment.
let's start with no-value marker, we can do that later?
fix: #70