Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the JSON schema for the security_rule Kibana asset #1066

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

rw-access
Copy link
Contributor

Issues

Realized in elastic/integrations#797 and some EPM observations that this isn't structured like other Kibana assets. EPM expects Kibana assets to look like this:

{
  "id": "Whatever the object ID string is, not necessarily enforced as UUID",

  // optional references whatever these are
  "references": null || [],

  // optional info that we don't need
  "migrationVersion": null || {}, 

  // this is where the data is ultimately stored
  "attributes": { ... },

  // type of asset that matches the folder
  "type": "security_rule";
}

We don't have to make attributes internally consistent with other saved objects, but we might want to.

We can still write our own installer in EPM anyway. See the reference on AssetInstallers to see how index patterns are installed separately from other assets.

Summary

References:

Copy link
Collaborator

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one requested change, then LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants