Fix kibana-upload and remove cumbersome dataclasses #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #121
Summary
dataclasses-json was silently dropping fields, and drifted from the JSON schemas.
index
wasn't included in the RuleResource class definition, the field was silently dropped. I removed the dataclasses-json approach, and just made RuleResource a subclass of dict instead. There is no validation in the schema, and I think that it's okay to make the client validate, since all of that code is there.Here's the payload after the changes