Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate linted .ts in package #49

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Generate linted .ts in package #49

merged 2 commits into from
Jul 9, 2020

Conversation

rw-access
Copy link
Contributor

Issues

None

Summary

We failed lint tests for elastic/kibana#71332. Now the generated .ts files should pass the lint unit tests.

Contributor checklist

@rw-access rw-access added the bug Something isn't working label Jul 9, 2020
@rw-access rw-access requested a review from brokensound77 July 9, 2020 22:50
@rw-access rw-access changed the base branch from main to 7.9 July 9, 2020 22:51
brokensound77
brokensound77 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one nit, otherwise LGTM 👍

@rw-access @brokensound77
(Lin|ni)t changes
48db253 
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
@rw-access rw-access merged commit e96eaba into elastic:7.9 Jul 9, 2020
@rw-access rw-access deleted the fix/packaging branch July 9, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brokensound77 brokensound77 brokensound77 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rw-access @brokensound77