Add versioned schemas with a downgrade path #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spong
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Schema diff between 7.8 and 7.9 LGTM!
Added fields in 7.9 are as follows, and those are indeed absent from what you have for 7.8 👍
New fields in 7.9:
- severity_mapping
- author
- risk_score_mapping
- license
- rule_name_override
- timestamp_override
- building_block_type
New rule type in 7.9
- threshold
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #70
Summary
Updated the schemas so we can track with stack version. This way, with kibana-upload, we'll be able to upload to old versions of the stack, not just the latest version. Otherwise, we'll run into schema errors when we use fields that an old stack didn't know about like
authororlicense. Now, you can just downgrade a rule from 7.9 to 7.8, and as long as it was supported you can post it. New rule types likethresholdwill raise an exception.More @spong spamming: I added you to check that I correctly captured the changes between 7.8 and 7.9.