-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate an integrations package from a release #983
Generate an integrations package from a release #983
Conversation
UUID_PATTERN = r'[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}' | ||
|
||
_version = r'\d+\.\d+(\.\d+[\w-]*)*' | ||
CONDITION_VERSION_PATTERN = rf'^\^{_version}$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we'll loosen this up as we go. might move from ^
to ~
or something.
no changes needed here, just an fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know - can always expand it here
"""Initialize a package.""" | ||
self.rules: List[Rule] = [r.copy() for r in rules] | ||
self.rules = [r.copy() for r in rules] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like type inspection has figured it out. I think we could annotate the Rule.copy
method to explicitly mention a return type of Rule
, but PyCharm at least is pretty smart
|
||
assert self.registry_data | ||
|
||
manifest = RegistryPackageManifest.from_dict(self.registry_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense to give this class an already assembled RegistryPackageManifest, but we can do this later with a restructur
10c6cbe
to
4117d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, @brokensound77. I left one comment for your review. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "and dependencies (e.g. ML jobs)"
from the readme_text
and this LGTM!
Issues
related to elastic/package-storage#843
Summary
This generates a package in the format expected by
package-storage
for use with the integrations process. The package is generated along with the other artifacts fromPackaging
and can be built withmake release
ordev build-release
.To see this with WIP changelog code along with more comprehensive changes, refer to this diff.
To see the package built with this PR, refer to the checks