Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CN PHP API to asciidoctor #1082

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 19, 2019

Let's start on the translations!

Let's start on the translations!
@nik9000 nik9000 changed the title Sitch CN PHP API to asciidoctor Switch CN PHP API to asciidoctor Aug 19, 2019
@nik9000
Copy link
Member Author

nik9000 commented Aug 19, 2019

I believe this'll fail in CI. I'll see about fixing the destination repo.

@nik9000
Copy link
Member Author

nik9000 commented Aug 19, 2019

@elasticmachine, run elasticsearch-ci/docs

2 similar comments
@nik9000
Copy link
Member Author

nik9000 commented Aug 19, 2019

@elasticmachine, run elasticsearch-ci/docs

@nik9000
Copy link
Member Author

nik9000 commented Aug 20, 2019

@elasticmachine, run elasticsearch-ci/docs

@nik9000
Copy link
Member Author

nik9000 commented Aug 20, 2019

If anyone is following along at home, I made a PR with this change and let CI tell me if the book compiled with asciidoctor or not. It did, but it had broken links in asciidoctor. I checked the book out locally and fixed the link in asciidoctor. Once I pushed that I let the global docs job rebuild the book then I reran CI for this PR. It passed! I used the html_diff tool in the docs repo to check the difference between the preview branch and the master branch and found a couple more links that were weird. I fixed them, pushed that, let the global docs build run, and now I'm checking CI for this PR for what is hopefully the last time!

@nik9000
Copy link
Member Author

nik9000 commented Aug 20, 2019

OK! The changes look like just inline anchors and some indentation in code examples. I'm calling that good enough!

@nik9000 nik9000 merged commit 2ec175e into elastic:master Aug 20, 2019
@nik9000 nik9000 mentioned this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant