Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Obs Guide chunk level #3045

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Aug 9, 2024

We need to bump the chunk level to accommodate the new Obs IA.

@dedemorton dedemorton self-assigned this Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@dedemorton
Copy link
Contributor Author

I need to cleanup some of the source files before this PR will be ready. The good news is that most of the discrepancies (when comparing file count for master with this branch) are in newer source files so we don't have to backport too far.

Rhodas-MBP:myscripts$ ./countfiles.sh
counting files in docs_bk_3045
Checking out branch....
Counting files....
Files in 8.8
     347
Files in 8.9
     358
Files in 8.10
     362
Files in 8.11
     371
Files in 8.12
     397
Files in 8.13
     573
Files in 8.14
     669
Files in 8.15
     677
Rhodas-MBP:myscripts$ ./countfiles.sh
counting files in master
Checking out branch....
Counting files....
Files in 8.8
     347
Files in 8.9
     358
Files in 8.10
     362
Files in 8.11
     371
Files in 8.12
     378
Files in 8.13
     554
Files in 8.14
     604
Files in 8.15
     612

@dedemorton
Copy link
Contributor Author

Looks like this is ready to go. Comparison of file count across affected versions checks out.

Rhodas-MBP:myscripts$ ./countfiles.sh
Checking out master...
Already on 'master'
Your branch is up to date with 'origin/master'.
Counting files in master...
Files in 8.8
     347
Files in 8.9
     358
Files in 8.10
     362
Files in 8.11
     371
Files in 8.12
     378
Files in 8.13
     554
Files in 8.14
     604
Files in 8.15
     612
Files in master
     612
Checking out docs_bk_3045...
Updating files: 100% (2045/2045), done.
Switched to branch 'docs_bk_3045'
Your branch is up to date with 'origin/docs_bk_3045'.
Counting files in docs_bk_3045...
Files in 8.8
     347
Files in 8.9
     358
Files in 8.10
     362
Files in 8.11
     371
Files in 8.12
     378
Files in 8.13
     554
Files in 8.14
     604
Files in 8.15
     612
Files in master
     612

@dedemorton dedemorton marked this pull request as ready for review August 15, 2024 22:33
@dedemorton dedemorton requested a review from a team as a code owner August 15, 2024 22:33
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dedemorton dedemorton merged commit a11258b into elastic:master Aug 19, 2024
3 checks passed
@dedemorton dedemorton deleted the bump_obs_chunk_level branch August 19, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants