Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about --resources parameter #372

Closed
wants to merge 1 commit into from

Conversation

cbuescher
Copy link
Member

@cbuescher cbuescher commented Jun 6, 2018

After the x-pack merge, building the Elasticsearch reference documentation
requires specifying additional resources using the --resource parameter.
This change adds a note to check the doc_build_aliases.sh file if ommiting this
parameter leads to errors and adds an example for building the reference
documentation.

After the x-pack merge, building the Elasticsearch reference documentation
requires specifying additional resources using the `--resource` parameter.
This change adds a note to check the doc_build_aliases.sh file if ommiting this
parameteer leads to errors and adds an example for building the reference
documentation.
@cbuescher cbuescher requested a review from lcawl June 6, 2018 10:54
@cbuescher
Copy link
Member Author

Since I ran into this and it took me a bit to understand whats wrong I think some sort of note is useful. Maybe there are other places where this fits in better, please let me know.

@cbuescher cbuescher added enhancement Something we'd like to improve docs DO NOT USE for *contents* of our docs. Only use for documentation *about* this repo. labels Jun 6, 2018
@lcawl
Copy link
Contributor

lcawl commented Jun 6, 2018

@cbuescher That build command will change again shortly (i.e. the --resources parameter will no longer be required when elastic/elasticsearch#30665 is complete). In general I think it's best to encourage people to use that aliases file, since we keep that up-to-date with the changes.

@cbuescher
Copy link
Member Author

That build command will change again shortly (i.e. the --resources parameter will no longer be required when elastic/elasticsearch#30665 is complete)

Didn't know that, I guess mentioning the alias file is suffiecient then, I just didn't know it yet. We can close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs DO NOT USE for *contents* of our docs. Only use for documentation *about* this repo. enhancement Something we'd like to improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants