Docker: Fix docs path mounting #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the paths that docs repos are mounted into the container when
`--doc` and `--resource` are used to allow building more books. These
books expect the all repositories to be cloned into the same root
directory which is "normal" but isn't exactly how docker did it. It *is*
how `--all` does it. But users don't always do it that way....
This fixes the mounted paths so they are always mounted into
`/doc/{reponame}` in docker. Which *should* make the paths even more
consistent then when they are built locally. This should make it
possible to build the stack reference with docker.
Relates to elastic#591
|
I'm so glad the script is in python and not shell. |
ddillinger
approved these changes
Feb 12, 2019
| repo_name = basename(repo_root) | ||
| if repo_root not in mounted_doc_repo_roots: | ||
| if repo_name in mounted_doc_repo_names: | ||
| raise ArgError("Can't mount two repos with the same " + |
There was a problem hiding this comment.
This is some good thinkin' right here
|
❤️ @ddillinger! |
nik9000
added a commit
that referenced
this pull request
Feb 15, 2019
Fix the paths that docs repos are mounted into the container when
`--doc` and `--resource` are used to allow building more books. These
books expect the all repositories to be cloned into the same root
directory which is "normal" but isn't exactly how docker did it. It *is*
how `--all` does it. But users don't always do it that way....
This fixes the mounted paths so they are always mounted into
`/doc/{reponame}` in docker. Which *should* make the paths even more
consistent then when they are built locally. This should make it
possible to build the stack reference with docker.
Relates to #591
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the paths that docs repos are mounted into the container when
--docand--resourceare used to allow building more books. Thesebooks expect the all repositories to be cloned into the same root
directory which is "normal" but isn't exactly how docker did it. It is
how
--alldoes it. But users don't always do it that way....This fixes the mounted paths so they are always mounted into
/doc/{reponame}in docker. Which should make the paths even moreconsistent then when they are built locally. This should make it
possible to build the stack reference with docker.
Relates to #591