-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switches X-Pack Reference to Asciidoctor builds #653
Conversation
This one is currently not building with:
Looks like some kind of bug. Not sure what though. |
@nik9000 Is that after fixing the issue with the path to the elasticsearch-extra folder per #505 (comment) ? Those are the errors I'm seeing with --lenient |
I was getting that error with |
I think it's the same error. I get a similar partintro error when I build the individual book without --lenient. |
The aforementioned error was caused by a |
The documentation build errors seem to be solved by #721 |
376c30d
to
dfca6dc
Compare
This seems to fail to build in the 5.6 branch. |
This one is now blocked on #824. |
I'm regenerating the diff for this one now. |
The differences seem to amount to:
At this point switching to Asciidoctor is a net positive on the results so I think we should merge this. I don't think any of the problems are worth going back and fixing at this point. But that is just my opinion. |
@lcawl, I'm going to leave the merging this to you. If you agree with my reasoning then merge when ready1 |
This PR updates the X-Pack Reference (https://www.elastic.co/guide/en/x-pack/index.html) such that it's built via Asciidoctor.
Related to #606