Asciidoctor: Implement beta and experimental #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the `beta[]` and `experimental[]` macros for asciidoctor. It adds integration tests that make sure that we copy the required image even if that is the only admonition in the book. This is an especially good idea here because the code that copies the images for the admonitions is a little sneaky.
|
Thanks, this fixes beta[] for the Stack Overview (#649) |
ninaspitfire
approved these changes
Mar 5, 2019
README.asciidoc
Outdated
| //// | ||
| This file contains the sequence `_` to escape from around Elastic's | ||
| Asciidoctor plugin that provides Asciidoc compatibility. It automatically | ||
| translates things like `beta[]` into their Asciidoctor compatible for |
|
Thanks for reviewing @jarpy! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
beta[]andexperimental[]macros for asciidoctor. Itadds integration tests that make sure that we copy the required image
even if that is the only admonition in the book. This is an especially
good idea here because the code that copies the images for the
admonitions is a little sneaky.