Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the community clients book to Asciidoctor #692

Merged
merged 1 commit into from
Mar 10, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 8, 2019

Switches the community clients book in the Elasticsearch repo to
Asciidoctor. The generated html has some spacing differences but our
tuned html_diff tool doesn't think that there are any differences that
are impactful.

Switches the community clients book in the Elasticsearch repo to
Asciidoctor. The generated html has some spacing differences but our
tuned html_diff tool doesn't think that there are any differences that
are impactful.
@nik9000 nik9000 requested a review from lcawl March 8, 2019 20:31
@nik9000 nik9000 mentioned this pull request Mar 8, 2019
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully

@nik9000 nik9000 merged commit 3b6eaf0 into elastic:master Mar 10, 2019
@nik9000
Copy link
Member Author

nik9000 commented Mar 10, 2019

Thanks for reviewing @lcawl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants