Asciidoctor: Change invocation rules for macros #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the invocation rules for legacy style admonition macros to only invoke the block version if it is alone on a line. This more closely mirrors the customizations that Elastic did to AsciiDoc.
|
I'm running a full rebuild into the |
|
I think this may actually cause trouble. I'll investigate! |
|
I tracked down the issue and pushed a fix. Then I started another build. |
That build says that this change doesn't change anything unexpected. :success: |
estolfo
approved these changes
Apr 15, 2019
|
Thanks for reviewing @estolfo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the invocation rules for legacy style admonition macros to only
invoke the block version if it is alone on a line. This more closely
mirrors the customizations that Elastic did to AsciiDoc.