chore: expose logger and use it, simplifying initialisation

elastic · Apr 30, 2021 · a89325c · a89325c
1 parent 30b5d8d
commit a89325c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/cli/config/config.go b/cli/config/config.go
@@ -124,7 +124,7 @@ func Init() {
 		return
 	}
 
-	configureLogger()
+	ConfigureLogger()
 
 	binaries := []string{
 		"docker",
@@ -246,7 +246,8 @@ func checkConfigDirs(workspace string) {
 	}).Trace("'op' workdirs created.")
 }
 
-func configureLogger() {
+// ConfigureLogger sets the log for the application
+func ConfigureLogger() {
 	includeTimestamp := os.Getenv("OP_LOG_INCLUDE_TIMESTAMP")
 	fullTimestamp := (strings.ToUpper(includeTimestamp) == "TRUE")
 

diff --git a/cli/config/config_test.go b/cli/config/config_test.go
@@ -42,7 +42,7 @@ func TestConfigureLoggerWithTimestamps(t *testing.T) {
 	os.Setenv("OP_LOG_INCLUDE_TIMESTAMP", "true")
 	defer cleanUpEnv()
 
-	configureLogger()
+	ConfigureLogger()
 
 	logger := logrus.New()
 
@@ -104,7 +104,7 @@ func checkLoggerWithLogLevel(t *testing.T, level string) {
 		level = "INFO"
 	}
 
-	configureLogger()
+	ConfigureLogger()
 
 	logLevel := logrus.GetLevel()
 

diff --git a/e2e/_suites/helm/helm_charts_test.go b/e2e/_suites/helm/helm_charts_test.go
@@ -63,7 +63,7 @@ var tx *apm.Transaction
 var stepSpan *apm.Span
 
 func setupSuite() {
-	config.Init()
+	config.ConfigureLogger()
 
 	developerMode = shell.GetEnvBool("DEVELOPER_MODE")
 	if developerMode {

diff --git a/e2e/_suites/kubernetes-autodiscover/autodiscover_test.go b/e2e/_suites/kubernetes-autodiscover/autodiscover_test.go
@@ -469,7 +469,7 @@ func InitializeTestSuite(ctx *godog.TestSuiteContext) {
 
 	ctx.BeforeSuite(func() {
 		// init logger
-		config.Init()
+		config.ConfigureLogger()
 
 		err := cluster.Initialize(suiteContext, "testdata/kind.yml")
 		if err != nil {