Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Commit

Permalink
fix: double quote tags if they are set (#531)
Browse files Browse the repository at this point in the history
* fix: double quote tags if they are set

* chore: control skip tags too
  • Loading branch information
mdelapenya committed Dec 4, 2020
1 parent 1847401 commit c2857e5
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion e2e/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ ifeq ($(SKIP_SCENARIOS),true)
## We always want to skip scenarios tagged with @skip
TAGS+= && ~skip
endif

# Double quote only if the tags are set
TAGS_VALUE="$(TAGS)"
else
ifeq ($(SKIP_SCENARIOS),true)
TAGS_FLAG=--tags
TAGS_VALUE="~skip"
endif
endif

GO_IMAGE_TAG?='stretch'
Expand Down Expand Up @@ -54,7 +62,7 @@ functional-test: install-godog
TIMEOUT_FACTOR=${TIMEOUT_FACTOR} \
STACK_VERSION=${STACK_VERSION} \
DEVELOPER_MODE=${DEVELOPER_MODE} \
godog --format=${FORMAT} ${TAGS_FLAG} "${TAGS}"
godog --format=${FORMAT} ${TAGS_FLAG} ${TAGS_VALUE}

.PHONY: lint
lint:
Expand Down

0 comments on commit c2857e5

Please sign in to comment.