Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: use a version of kibana with the fix for fleet-server validations #1055

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Apr 20, 2021

What does this PR do?

It uses kibana:pr96718, which includes a fix for fleet-server validations.

Why is it important?

We want to make sure the tests are healthy in this point of the history

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • Built and push kibana image using the CI (docker.elastic.co/observability-ci/kibana:pr96718

How to test this PR locally

Fleet tests are back to green:

 SUITE="fleet" TAGS="fleet_mode_agent && centos && enroll" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=false DEVELOPER_MODE=true make -C e2e functional-test

Related issues

adam-stokes and others added 4 commits April 19, 2021 16:07
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
@mdelapenya mdelapenya self-assigned this Apr 20, 2021
@mdelapenya mdelapenya requested a review from a team April 20, 2021 09:10
@mdelapenya
Copy link
Contributor Author

The fleet server tests will probably fail at this point: we are working in switching from kibana enrollment to fleet-server enrollment

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1055 opened

  • Start Time: 2021-04-20T09:10:26.032+0000

  • Duration: 40 min 13 sec

  • Commit: a483dde

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

@adam-stokes adam-stokes merged commit c6f1176 into elastic:master Apr 20, 2021
mergify bot pushed a commit that referenced this pull request Apr 20, 2021
#1055)

* Fix kibana config for fleet server

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Do not force fleet recreation as no fleet server exists yet

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Revert "Do not force fleet recreation as no fleet server exists yet"

This reverts commit e640941.

* fix: force a valid version of kibana

Co-authored-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
(cherry picked from commit c6f1176)
mdelapenya added a commit that referenced this pull request Apr 21, 2021
…s (backport #1055) (#1063)

* fix: use a version of kibana with the fix for fleet-server validations (#1055)

* Fix kibana config for fleet server

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Do not force fleet recreation as no fleet server exists yet

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Revert "Do not force fleet recreation as no fleet server exists yet"

This reverts commit e640941.

* fix: force a valid version of kibana

Co-authored-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
(cherry picked from commit c6f1176)

* fix: use a 7.x version of the same image

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Apr 21, 2021
* master:
  v2 refactor (elastic#1008)
  fix: use a version of kibana with the fix for fleet-server validations (elastic#1055)
  feat: add first scenario for Fleet Server (elastic#900)
  fix: do not use GT_REPO variable, use fixed repo name instead (elastic#1049)
@mdelapenya mdelapenya deleted the fleet-server branch April 22, 2021 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants