This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: branch_specifier is needed #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures> Show only the first 10 test failures
|
.ci/build-docker-images.groovy
Outdated
| @@ -25,7 +25,7 @@ pipeline { | |||
| quietPeriod(10) | |||
| } | |||
| triggers { | |||
| cron 'H H(0-5) * * 1-5' | |||
| cron '@daily' | |||
There was a problem hiding this comment.
do not use daily, it will run on weekends, and 24h after the last execution so the time is not fixed.
There was a problem hiding this comment.
Ok, I used what we added in the apm-pipeline-library for building images: https://github.com/elastic/apm-pipeline-library/blob/master/.ci/jobs/beats-docker-images-pipeline.yml#L27
What is the recommended cron trigger? Maybe weekly/monthly is enough
There was a problem hiding this comment.
'H H(0-5) * * 1-5' Monday to Friday anytime between 00:00 AM to 05:00 AM this is fine, the key is to set a range (H(0-5)) of hours where the build can run, Jenkins will manage to not overload the instance in that range.
There was a problem hiding this comment.
Ok, this is what we use for the nightly scheduled pipelines. Will use what we have in there
v1v
reviewed
Apr 27, 2021
cachedout
approved these changes
Apr 27, 2021
mdelapenya
commented
Apr 27, 2021
| triggers { | ||
| cron 'H H(0-5) * * 1-5' | ||
| cron 'H H(4-5) * * 1-5' |
There was a problem hiding this comment.
Use same cron than in the nightly builds
v1v
reviewed
Apr 27, 2021
v1v
reviewed
Apr 27, 2021
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Done 😊 I used lowercase for params and uppercase for env vars on purpose, as I thought there was a naming convention. If it's not there, we can add it to the shared library docs. |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Log outputExpand to view the last 100 lines of log output
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Apr 27, 2021
* master: Support fleet-server-service-token (elastic#1096) fix: use wider selector for ARM workers (elastic#1103) feat: bootstrap fleet-server for the deployment of regular elastic-agents (elastic#1078) fix: use proper variable name (elastic#1102) fix: branch_specifier is needed (elastic#1097) Move kubernetes/kubectl/kind code to internal project layout (elastic#1092) fix: update JJBB with proper values (elastic#1093) feat: support building centos/debian Docker images in multiplatform format (elastic#1091) Kubernetes autodiscover suite (elastic#1064)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It reverts dddba26, as the branch_specifier is required, although failing the first time the build is executed (params are not there).
We are changing the schedued trigger to daily
Why is it important?
Checklist
make noticein the proper directory)Author's Checklist
Related issues