Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: bump stale agent to 7.13-SNAPSHOT #1146

Merged
merged 1 commit into from
May 6, 2021

Conversation

mdelapenya
Copy link
Contributor

What does this PR do?

It uses one minor version for the stale agent

Why is it important?

For master branch, using 8.0.0-SNAPSHOT, it's incorrect to use 7.11-SNAPSHOT as stale agent, as that version has disappeared from the artifactory.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • @michalpristas, can you confirm that the stale version is correct for master?

Follow-ups

Thinkg about upgrade processes, what if we want to test the upgrade of an old version? Using the artifact repository won't be enough, as versions disappears after 2 minor versions of the stack.

Maybe this is something to ask infra, about allowing accessing those old versions from another repository.

@mdelapenya mdelapenya self-assigned this May 6, 2021
@mdelapenya mdelapenya requested a review from a team May 6, 2021 08:32
@elasticmachine
Copy link
Contributor

elasticmachine commented May 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Manuel de la Peña

  • Start Time: 2021-05-06T08:53:41.726+0000

  • Duration: 14 min 16 sec

  • Commit: fb36df1

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

@mdelapenya mdelapenya marked this pull request as ready for review May 6, 2021 08:53
@mdelapenya
Copy link
Contributor Author

I'm triggering the CI job running the nightly tests, as the upgrade test is run in that schedule

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mdelapenya mdelapenya merged commit 044a642 into elastic:master May 6, 2021
@mdelapenya mdelapenya deleted the bump-stale-agent branch May 6, 2021 09:31
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request May 6, 2021
* master:
  chore: rename downloaded file (elastic#1149)
  fix: bump stale agent to 7.13-SNAPSHOT (elastic#1146)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants