This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
fix: do not use variable out of its scope #1231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
cachedout
approved these changes
Jun 2, 2021
adam-stokes
approved these changes
Jun 2, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit 070e552)
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit 070e552)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 2, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 2, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jun 2, 2021
mdelapenya
added a commit
that referenced
this pull request
Jun 2, 2021
mdelapenya
added a commit
that referenced
this pull request
Jun 2, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It avoids using the
platform
variable out of its Groovy scope.Why is it important?
The pipeline will fail whenever the else branch of the isGitRegionMatch is false. This bug will appear whenever there is a replay in the pipeline, or there are no changes in the git-regions defined by the regex. Before these changes, the log entry in the else branch would try to print the platform, which was declared in the if branch of the evaluation.
Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)Related issues
Follows-up
Backport to 7.x and 7.13.x